linux-kernel - Re: [PATCH v2 3/8] arm: add device-tree SoC bindings for Axis Artpec-6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7242985.WgQduhPVkk@wuerfel>
Date:	Thu, 11 Feb 2016 15:14:56 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Lars Persson <lars.persson@...s.com>, devicetree@...r.kernel.org,
	linux-clk@...r.kernel.org, mark.rutland@....com,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	Lars Persson <larper@...s.com>, linux-kernel@...r.kernel.org,
	robh+dt@...nel.org, galak@...eaurora.org
Subject: Re: [PATCH v2 3/8] arm: add device-tree SoC bindings for Axis Artpec-6

On Thursday 11 February 2016 15:04:37 Lars Persson wrote:
> +
> +The DMA configuration unit muxes dma request lines between single and burst
> +alternatives.
> +
> +Required properties:
> +- compatible: axis,artpec6-dmacfg
> +- reg: Address and length of DMACFG register.
> +
> +Example:
> +       dmacfg {
> +               compatible = "axis,artpec6-dmacfg";
> +               reg = <0xf8000010 4>;
> +       };
> +

This method looks better than before, but putting a single register
into DT looks wrong. I can almost guarantee that there are more
registers at 0xf8000000-0xf8000fff (or more) that belong to either
some system controller or a DMA controller.

Whatever it is, please describe it in the DT in a sensible way based
on what the hardware does and what other resources it uses (interrupts
etc) rather than what today's kernel happens to need.

	Arnd