linux-kernel - Re: [PATCH 2/4] acct,time: change indentation in __acct_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1455153818.3333.55.camel@perches.com>
Date:	Wed, 10 Feb 2016 17:23:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	riel@...hat.com, linux-kernel@...r.kernel.org
Cc:	fweisbec@...il.com, tglx@...utronix.de, mingo@...nel.org,
	luto@...capital.net, peterz@...radead.org, clark@...hat.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH 2/4] acct,time: change indentation in
 __acct_update_integrals

On Wed, 2016-02-10 at 20:08 -0500, riel@...hat.com wrote:
> Change the indentation in __acct_update_integrals to make the function
> a little easier to read.

trivia:

> diff --git a/kernel/tsacct.c b/kernel/tsacct.c
[]
> @@ -125,31 +125,32 @@ void xacct_add_tsk(struct taskstats *stats, struct task_struct *p)
[]
> +	if (!likely(tsk->mm))
> +		return;

Using

	if (unlikely(!tsk->mm))
		return;

would be a lot more common.

(~150:1 in the kernel sources)