linux-kernel - [PATCH] HID: fix hid_ignore_special

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1455293437-12088-1-git-send-email-benjamin.tissoires@redhat.com>
Date:	Fri, 12 Feb 2016 17:10:37 +0100
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] HID: fix hid_ignore_special_drivers module parameter

hid_ignore_special_drivers works fine until hid_scan_report
autodetects and reassign devices (for hid-multitouch,
hid-microsoft and hid-rmi).

Simplify the handling of the parameter: if it is there, use
hid-generic, no matter what, and if not, scan the device or
rely on the hid_have_special_driver table.

This was detected while trying to disable hid-multitouch on
a Surface Pro cover which prevented to use the keyboard.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
CC: stable@...r.kernel.org
---

Hi Jiri,

not sure if we should keep or not the stable@ tag. The issue was there for a
long time, and nobody complained. It's up to you.

Cheers,
Benjamin

 drivers/hid/hid-core.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index e637e4f..fe8be16 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2661,9 +2661,10 @@ int hid_add_device(struct hid_device *hdev)
 	/*
 	 * Scan generic devices for group information
 	 */
-	if (hid_ignore_special_drivers ||
-	    (!hdev->group &&
-	     !hid_match_id(hdev, hid_have_special_driver))) {
+	if (hid_ignore_special_drivers) {
+		hdev->group = HID_GROUP_GENERIC;
+	} else if (!hdev->group &&
+		   !hid_match_id(hdev, hid_have_special_driver)) {
 		ret = hid_scan_report(hdev);
 		if (ret)
 			hid_warn(hdev, "bad device descriptor (%d)\n", ret);
-- 
2.5.0