linux-kernel - RE: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002e01d1662c$0579d640$106d82c0$@codeaurora.org>
Date:	Sat, 13 Feb 2016 12:28:50 +0530
From:	"Sricharan" <sricharan@...eaurora.org>
To:	"'Wolfram Sang'" <wsa@...-dreams.de>
Cc:	<devicetree@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
	<agross@...eaurora.org>, <linux-kernel@...r.kernel.org>,
	<linux-i2c@...r.kernel.org>, <iivanov@...sol.com>,
	<galak@...eaurora.org>, <dmaengine@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <andy.gross@...aro.org>,
	<ntelkar@...eaurora.org>, <architt@...eaurora.org>
Subject: RE: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities

Hi Wolfram,

> -----Original Message-----
> From: Wolfram Sang [mailto:wsa@...-dreams.de]
> Sent: Saturday, February 13, 2016 12:08 AM
> To: Sricharan R
> Cc: devicetree@...r.kernel.org; linux-arm-msm@...r.kernel.org;
> agross@...eaurora.org; linux-kernel@...r.kernel.org; linux-
> i2c@...r.kernel.org; iivanov@...sol.com; galak@...eaurora.org;
> dmaengine@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> andy.gross@...aro.org; ntelkar@...eaurora.org; architt@...eaurora.org
> Subject: Re: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities
> 
> On Tue, Jan 19, 2016 at 03:32:44PM +0530, Sricharan R wrote:
> > QUP cores can be attached to a BAM module, which acts as a dma engine
> > for the QUP core. When DMA with BAM is enabled, the BAM consumer
> pipe
> > transmitted data is written to the output FIFO and the BAM producer
> > pipe received data is read from the input FIFO.
> >
> > With BAM capabilities, qup-i2c core can transfer more than
> > 256 bytes, without a 'stop' which is not possible otherwise.
> >
> > Signed-off-by: Sricharan R <sricharan@...eaurora.org>
> > Reviewed-by: Andy Gross <andy.gross@...aro.org>
> > Tested-by: Archit Taneja <architt@...eaurora.org>
> > Tested-by: Telkar Nagender <ntelkar@...eaurora.org>
> 
> My code checkers found some issues:
> 
>     SPARSE
> drivers/i2c/busses/i2c-qup.c:555:6: warning: symbol 'qup_sg_set_buf' was
> not declared. Should it be static?
> drivers/i2c/busses/i2c-qup.c:1243:50: warning: dubious: !x & !y
>     SMATCH
> drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s =
> sg_next()
> drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s =
> sg_next()
> drivers/i2c/busses/i2c-qup.c:1243 qup_i2c_xfer_v2() warn: add some
> parenthesis here?
>     CPPCHECK
> drivers/i2c/busses/i2c-qup.c:1243: style: Boolean result is used in
bitwise
> operation. Clarify expression with parentheses.
>     SPATCH
> drivers/i2c/busses/i2c-qup.c:1380:2-13: WARNING: Assignment of bool to 0/1
> drivers/i2c/busses/i2c-qup.c:1481:1-13: WARNING: Assignment of bool to 0/1
>   CC      drivers/i2c/busses/i2c-qup.o
> drivers/i2c/busses/i2c-qup.c:555:6: warning: no previous prototype for
> 'qup_sg_set_buf' [-Wmissing-prototypes]  void qup_sg_set_buf(struct
> scatterlist *sg, void *buf, struct qup_i2c_tag *tg,
> 
> Can you fix them and resend??

    Sorry on this , will resend this patch.

Regards,
 Sricharan