lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Feb 2016 08:46:39 +0900 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Laxman Dewangan <ldewangan@...dia.com>, lee.jones@...aro.org, alexandre.belloni@...e-electrons.com, javier@....samsung.com, broonie@...nel.org, gregkh@...uxfoundation.org, a.zummo@...ertech.it Cc: cw00.choi@...sung.com, linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com Subject: Re: [PATCH V7 4/5] mfd: max77686: do not set i2c client data for rtc i2c client On 10.02.2016 02:26, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no call to i2c_get_clientdata() for rtc_i2c client, > there is no need to store pointer and hence removing the call > to set client data for rtc i2c client. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> > Signed-off-by: Laxman Dewangan <ldewangan@...dia.com> > CC: Krzysztof Kozlowski <k.kozlowski@...sung.com> > CC: Javier Martinez Canillas <javier@....samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> > Tested-by: Javier Martinez Canillas <javier@....samsung.com> > Reviewed-by: Javier Martinez Canillas <javier@....samsung.com> > FWIW, on max77686: Tested-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> Best regards, Krzysztof
Powered by blists - more mailing lists