linux-kernel - Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM2PR04MB0690B9C2BAAAB6195F225A6BE3AC0@AM2PR04MB0690.eurprd04.prod.outlook.com>
Date:	Mon, 15 Feb 2016 11:30:36 +0000
From:	Fabio Estevam <fabio.estevam@....com>
To:	Mika Penttilä <mika.penttila@...tfour.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"mail@...iej.szmigiero.name" <mail@...iej.szmigiero.name>,
	"festevam@...il.com" <festevam@...il.com>,
	"broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc

[Sorry for the top post, can't reply properly from this Inbox]

Could you please try applying this commit from linux-next?
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf

Thanks,

Fabio Estevam

________________________________________
From: Mika Penttilä <mika.penttila@...tfour.com>
Sent: Monday, February 15, 2016 9:25 AM
To: LKML; mail@...iej.szmigiero.name; Fabio Estevam
Subject: [REGRESSION, bisected] 4.5rc4 sound fsl-soc

Hi,

The following commit :

5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit
commit 5c408fee254633a5be69505bc86c6b034f871ab4
Author: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
Date:   Mon Jan 18 20:07:44 2016 +0100

    ASoC: fsl_ssi: remove explicit register defaults

    There is no guarantee that on fsl_ssi module load
    SSI registers will have their power-on-reset values.

    In fact, if the driver is reloaded the values in
    registers will be whatever they were set to previously.

    However, the cache needs to be fully populated at probe
    time to avoid non-atomic allocations during register
    access.

    Special case here is imx21-class SSI, since
    according to datasheet it don't have SACC{ST,EN,DIS}
    regs.

    This fixes hard lockup on fsl_ssi module reload,
    at least in AC'97 mode.

    Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")
    Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
    Tested-by: Fabio Estevam <fabio.estevam@....com>
    Signed-off-by: Mark Brown <broonie@...nel.org>


causes regmap init failure when loading the sgtl5000 codec on imx6q, and
leads to no audio.

With the mentioned patch reverted sound works ok.

--Mika