linux-kernel - Re: [PATCH v7 RESEND 0/4] mailbox: hisilicon: add Hi6220 mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160215135426.GA10532@leoy-linaro>
Date:	Mon, 15 Feb 2016 21:54:26 +0800
From:	Leo Yan <leo.yan@...aro.org>
To:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Tyler Baker <tyler.baker@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Sudeep Holla <sudeep.holla@....com>,
	Bintian Wang <bintian.wang@...wei.com>,
	Chen Feng <puck.chen@...ilicon.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Wei Xu <xuwei5@...ilicon.com>
Subject: Re: [PATCH v7 RESEND 0/4] mailbox: hisilicon: add Hi6220 mailbox
 driver

On Mon, Feb 15, 2016 at 09:50:22PM +0800, Leo Yan wrote:
> Hi6220 mailbox supports up to 32 channels. Each channel is unidirectional
> with a maximum message size of 8 words. I/O is performed using register
> access (there is no DMA) and the cell raises an interrupt when messages
> are received.
> 
> This patch series is to implement Hi6220 mailbox driver. It registers
> two channels into framework for communication with MCU, one is tx channel
> and another is rx channel. Now mailbox driver is used to send message to
> MCU to control dynamic voltage and frequency scaling for CPU, GPU and DDR.
> 
> Changes from v6:
> * Fix to use lowercase for hexadecimal value in DT binding document

Hi Jassi,

Per your request, I have rebased patches over mailbox-for-next.

Hi Wei,

Could you help merge patch 3/4 for Hi6220's DTS?

Thanks,
Leo Yan

> 
> Changes from v5:
> * Refine to use mailbox three specifiers for client driver, so add xlate
>   callback function in mailbox driver to support these specifiers
> * Refine document for property "hi6220,mbox-tx-noirq"
> 
> Changes from v4:
> * According to Jassi's suggestion, using DT binding to register channels
> * Change to use operating-points-v2 to register operating points
> 
> Changes from v3:
> * The patch series for enabling idle state for Hi6220 has reserved memory
>   regions, so this series will not include it anymore
> * Refined mailbox driver according to Jassi's suggestion;
>   Removed kfifo from mailbox driver;
>   Removed spinlock for ipc registers accessing, due every channel has its
>   own dedicated bit in ipc register and readl/writel will introduce memory
>   barrier, so don't need spinlock to protect ipc registers accessing
> * After mailbox driver is ready, can use patch 4 to enable CPU's OPPs and
>   stub clock driver; finally can enable CPUFreq driver for CPU frequency
>   scaling
> 
> Changes from v2:
> * Get rid of unused memory regions from memory node in DT, and don't use
>   reserved-memory node according to Mark and Leif's suggestion; Haojian also
>   has updated UEFI for efi memory info
> 
> Changes from v1:
> * Correct lock usage for SMP scenario
> 
> Changes from RFC:
> * According to Jassi's review, totally remove the abstract common driver
>   layer and only commit driver dedicated for Hi6220
> * According to Paul Bolle's review, fix typo issue for Kconfig and remove
>   unnecessary dependency with OF and fix minor for mailbox driver
> * Refine a little for dts nodes
> 
> 
> Leo Yan (4):
>   dt-bindings: mailbox: Document Hi6220 mailbox driver
>   mailbox: Hi6220: add mailbox driver
>   arm64: dts: add mailbox node for Hi6220
>   arm64: dts: add Hi6220's stub clock node
> 
>  .../bindings/mailbox/hisilicon,hi6220-mailbox.txt  |  74 ++++
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi          |  64 ++++
>  drivers/mailbox/Kconfig                            |   8 +
>  drivers/mailbox/Makefile                           |   2 +
>  drivers/mailbox/hi6220-mailbox.c                   | 395 +++++++++++++++++++++
>  5 files changed, 543 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/hisilicon,hi6220-mailbox.txt
>  create mode 100644 drivers/mailbox/hi6220-mailbox.c
> 
> -- 
> 1.9.1
>