linux-kernel - Re: [PATCH] rtc: s3c: Document in binding that only s3c6410 needs a src clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Feb 2016 10:58:34 -0300
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	linux-samsung-soc@...r.kernel.org,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	rtc-linux@...glegroups.com, devicetree@...r.kernel.org
Subject: Re: [PATCH] rtc: s3c: Document in binding that only s3c6410 needs a
 src clk

Hello Alexandre,

On 02/15/2016 10:45 AM, Alexandre Belloni wrote:
> On 15/02/2016 at 10:16:42 -0300, Javier Martinez Canillas wrote :
>> Commit 43f3408261a2 ("rtc: s3c: Document required clocks in the DT
>
> I'm pretty sure you shouldn't refer to a commit that is in linux-next.
>

The commit comes from Rob's dt/linus branch that uses Linux 4.5-rc3 as
a base. I'm not a git expert but I thought that if the branch is not
rebased and used for the pull request then the resulting commit in
mainline would end with the same sha-1.

But I can remove the mention to the commit and "Fixes:" tag since the
commit is not yet in mainline, that should be more safe indeed.
  
>> binding") added to the S3C binding doc the required clocks needed
>> by the Real Time Clock but the S3C driver supports different HW IP
>> and only the s3c6410 needs a source clock.
>>
>> Fix the DT binding explaning that the second clock is only needed
>            explaining ^

Ok, I'll fix that typo.

>> by this IP block and not for the others.
>>
>> Reported-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>> Fixes: 43f3408261a2 ("rtc: s3c: Document required clocks in the DT binding")
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>>
>
> Anyway, I'm fine with it, feel free to add my ack.
>

Thanks, I'll add it in v2.
  
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America