linux-kernel - Re: [PATCH v3 2/3] staging: rtl8723au: core: rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Feb 2016 10:33:46 -0500
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Geliang Tang <geliangtang@....com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes

Geliang Tang <geliangtang@....com> writes:
> There are some useless codes in rtw_free_recvframe23a_queue() and
> recvframe_defrag(), so remove them.
>
> Signed-off-by: Geliang Tang <geliangtang@....com>
> ---
> Changes in v3:
>  - split it into three patches.
> Changes in v2:
>  - drop the coding style fixing in v1.
> ---
>  drivers/staging/rtl8723au/core/rtw_recv.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

I assume this requires patch 1/3 applied first?

Acked-by: Jes Sorensen <Jes.Sorensen@...hat.com>

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c
> index 18b7d03..b36bc6b 100644
> --- a/drivers/staging/rtl8723au/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723au/core/rtw_recv.c
> @@ -201,7 +201,6 @@ static void rtw_free_recvframe23a_queue(struct rtw_queue *pframequeue)
>  	spin_lock(&pframequeue->lock);
>  
>  	phead = get_list_head(pframequeue);
> -	plist = phead->next;
>  
>  	list_for_each_entry_safe(hdr, ptmp, phead, list) {
>  		rtw_free_recvframe23a(hdr);
> @@ -1567,7 +1566,7 @@ struct recv_frame *recvframe_defrag(struct rtw_adapter *adapter,
>  				    struct rtw_queue *defrag_q)
>  {
>  	struct list_head *plist, *phead;
> -	u8	*data, wlanhdr_offset;
> +	u8	wlanhdr_offset;
>  	u8	curfragnum;
>  	struct recv_frame *pnfhdr, *ptmp;
>  	struct recv_frame *prframe, *pnextrframe;
> @@ -1596,10 +1595,6 @@ struct recv_frame *recvframe_defrag(struct rtw_adapter *adapter,
>  
>  	curfragnum++;
>  
> -	phead = get_list_head(defrag_q);
> -
> -	data = prframe->pkt->data;
> -
>  	list_for_each_entry_safe(pnfhdr, ptmp, phead, list) {
>  		pnextrframe = (struct recv_frame *)pnfhdr;
>  		/* check the fragment sequence  (2nd ~n fragment frame) */