lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Feb 2016 18:24:57 +0100 From: Robert Jarzmik <robert.jarzmik@...e.fr> To: Vinod Koul <vinod.koul@...el.com> Cc: Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Daniel Mack <daniel@...que.org>, Haojian Zhuang <haojian.zhuang@...il.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org Subject: Re: [PATCH 4/4] dmaengine: pxa_dma: fix the maximum requestor line Vinod Koul <vinod.koul@...el.com> writes: > On Thu, Feb 11, 2016 at 10:23:18PM +0100, Robert Jarzmik wrote: >> @@ -1399,13 +1405,17 @@ static int pxad_probe(struct platform_device *op) >> return PTR_ERR(pdev->base); >> >> of_id = of_match_device(pxad_dt_ids, &op->dev); >> - if (of_id) >> + if (of_id) { >> of_property_read_u32(op->dev.of_node, "#dma-channels", >> &dma_channels); >> - else if (pdata && pdata->dma_channels) >> + of_property_read_u32(op->dev.of_node, "#requestors", >> + &nb_requestors); > > I think we should check the return value here. This might be err in case > when we have older DT on platform, but still should work with default in > that case Okay, but how should the code react to the err case, more specifically to -EINVAL or -ENODATA ? As this property is optional as per the device-tree description, the current code leaves nb_requestors = 0, as is specified in the description, and fits the mmp_pdma case. What do you think should be done ? A warning message ? Something else ? Cheers. -- Robert
Powered by blists - more mailing lists