linux-kernel - Re: [PATCH] Documentation: SubmittingPatches: Add note about Reviewed-by tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160215104330.22cbd8c9@lwn.net>
Date:	Mon, 15 Feb 2016 10:43:30 -0700
From:	Jonathan Corbet <corbet@....net>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH] Documentation: SubmittingPatches: Add note about
 Reviewed-by tags

On Thu, 11 Feb 2016 18:12:58 -0800
Florian Fainelli <f.fainelli@...il.com> wrote:

> As is now common in a lot of organization having an internal code review
> process (be it through Gerritt or other tools), patches extracted from
> this review process and submitted to public mailing-lists will have
> pre-existing Reviewed-by tags. Add a note about why these tags exists,
> and what a maintainer could be doing with those. Some maintainers did
> complain before that these tags had to be added when the patches get
> submitted to the public, while some just ignored and took the patches
> as-is.

So I'll confess, I'm not quite sold on this one.  This is a document for
people looking to learn about how to submit patches; it is already far
too long, complex, and bureaucratic.  I'm not at all convinced that
adding suggestions for maintainers is appropriate here.

Is there a real problem that this patch is trying to solve?

Thanks,

jon