linux-kernel - Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5AO4KY+PcQ7ka5Ot-TL222frLO50On+tFXFWGkKhQ25PA@mail.gmail.com>
Date:	Mon, 15 Feb 2016 18:54:29 -0200
From:	Fabio Estevam <festevam@...il.com>
To:	Clemens Gruber <clemens.gruber@...ruber.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"David S . Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior

On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber
<clemens.gruber@...ruber.com> wrote:

> +static int marvell_config_init(struct phy_device *phydev)
> +{
> +       int err;
> +
> +       /* Set registers from marvell,reg-init DT property */
> +       err = marvell_of_reg_init(phydev);
> +       if (err < 0)
> +               return err;
> +
> +       return 0;
>  }

Couldn't this be replaced by

return marvell_of_reg_init(phydev); ?