lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Feb 2016 23:34:24 +0100 From: Clemens Gruber <clemens.gruber@...ruber.com> To: Fabio Estevam <festevam@...il.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>, linux-kernel <linux-kernel@...r.kernel.org>, "David S . Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch> Subject: Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior Hi Fabio, On Mon, Feb 15, 2016 at 06:54:29PM -0200, Fabio Estevam wrote: > On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber > <clemens.gruber@...ruber.com> wrote: > > > +static int marvell_config_init(struct phy_device *phydev) > > +{ > > + int err; > > + > > + /* Set registers from marvell,reg-init DT property */ > > + err = marvell_of_reg_init(phydev); > > + if (err < 0) > > + return err; > > + > > + return 0; > > } > > Couldn't this be replaced by > > return marvell_of_reg_init(phydev); ? I wanted to add some missing errata fixes from the Marvell Release Notes into that function (in the near future). But you are right, I should probably not change things preemptively. I'll send a v3 with that part replaced! Thanks, Clemens
Powered by blists - more mailing lists