linux-kernel - Re: [PATCH] ARM: don't print missing L2 cache as error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Feb 2016 19:19:20 -0800
From:	Stefan Agner <stefan@...er.ch>
To:	linux@....linux.org.uk
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: don't print missing L2 cache as error

Hi Russel,

Any comment to this? Currently the kernel prints an error message as
follows on the platform at hand:
[    0.000000] L2C: failed to init: -19

--
Stefan


On 2016-01-27 17:27, Stefan Agner wrote:
> Not having a L2 cache controller is a shame, but not an error. Avoid
> printing an error message if L2 controller initialization returns
> with ENODEV.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
> Hi Russel,
> 
> We use a multiplatform kernel for two similar SoC's, one with L2
> cache the other without. Maybe silently ignore -ENODEV would be
> an option too, not sure what is preferred here.
> 
> --
> Stefan
> 
>  arch/arm/kernel/irq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
> index 1d45320e..f80c480 100644
> --- a/arch/arm/kernel/irq.c
> +++ b/arch/arm/kernel/irq.c
> @@ -95,7 +95,9 @@ void __init init_IRQ(void)
>  			outer_cache.write_sec = machine_desc->l2c_write_sec;
>  		ret = l2x0_of_init(machine_desc->l2c_aux_val,
>  				   machine_desc->l2c_aux_mask);
> -		if (ret)
> +		if (ret == -ENODEV)
> +			pr_info("L2C: no device found\n");
> +		else if (ret)
>  			pr_err("L2C: failed to init: %d\n", ret);
>  	}