linux-kernel - Re: [RFC PATCH] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbpysZVN3SGKbX+3rMaua8QBG1Qc0ABa3uVz2Rbfb8v7w@mail.gmail.com>
Date:	Tue, 16 Feb 2016 16:38:43 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	qiujiang <qiujiang@...wei.com>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linuxarm@...wei.com, haifeng.wei@...wei.com,
	charles.chenxin@...wei.com
Subject: Re: [RFC PATCH] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events
 support for power button

On Tue, Feb 16, 2016 at 1:32 PM, Jiang Qiu <qiujiang@...wei.com> wrote:
> 在 2016/2/16 2:25, Linus Walleij 写道:
>> Mika can you help out looking at this patch. Tell me if you need a copy
>> of the whole patch, I'm not smart with ACPI.
>>
>> On Fri, Feb 5, 2016 at 7:25 AM, qiujiang <qiujiang@...wei.com> wrote:
>>
>>> This patch modifies the DesignWare GPIO controller driver to
>>> support the GPIO-signaled ACPI Events. This is used for power
>>> button function on ARM server.
>>>
>>> To make it work, the _AEI and _EVT object must be defined in
>>> the corresponding GPIO driver's dsdt table in UEFI. At the same
>>> time, ACPI daemon component is also necessary.
>>>
>>> Signed-off-by: qiujiang <qiujiang@...wei.com>
>>
>> (...)
>>> --- a/drivers/gpio/gpio-dwapb.c
>>> +++ b/drivers/gpio/gpio-dwapb.c
>>> @@ -23,6 +23,11 @@
>>>  #include <linux/spinlock.h>
>>>  #include <linux/platform_data/gpio-dwapb.h>
>>>  #include <linux/slab.h>
>>> +#include <linux/acpi.h>
>>> +#include <linux/gpio.h>
>>
>> You should only need <linux/driver.h>
> Here, I don't understand well. I used driver.h instead acpi.h and
> gpio.h, but it came to compile failed.

Argh sorry.
<linux/gpio/driver.h>

Yours,
Linus Walleij