linux-kernel - Re: [PATCH] kbuild: fixdep: Check fstat(2) return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160216153215.GA19597@bill-the-cat>
Date:	Tue, 16 Feb 2016 10:32:15 -0500
From:	Tom Rini <trini@...sulko.com>
To:	linux-kbuild@...r.kernel.org
Cc:	Michal Marek <mmarek@...e.com>, lk <linux-kernel@...r.kernel.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH] kbuild: fixdep: Check fstat(2) return value

On Sat, Jan 16, 2016 at 02:11:16PM -0500, Tom Rini wrote:
> On Mon, Dec 7, 2015 at 4:26 PM, Tom Rini <trini@...sulko.com> wrote:
> 
> > Coverity has recently added a check that will find when we don't check
> > the return code from fstat(2).  Copy/paste the checking logic that
> > print_deps() has with an appropriate re-wording of the perror() message.
> >
> > Cc: Michal Marek <mmarek@...e.com>
> > Cc: linux-kbuild@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Signed-off-by: Tom Rini <trini@...sulko.com>
> >
> > ---
> > Note that I don't have a CID here was I found this in U-Boot and the
> > kernel hasn't yet done a build with this test being enabled.
> > ---
> >  scripts/basic/fixdep.c |    6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
> > index c68fd61..e3d9678 100644
> > --- a/scripts/basic/fixdep.c
> > +++ b/scripts/basic/fixdep.c
> > @@ -274,7 +274,11 @@ static void do_config_file(const char *filename)
> >                 perror(filename);
> >                 exit(2);
> >         }
> > -       fstat(fd, &st);
> > +       if (fstat(fd, &st) < 0) {
> > +               fprintf(stderr, "fixdep: error fstat'ing config file: ");
> > +               perror(filename);
> > +               exit(2);
> > +       }
> >         if (st.st_size == 0) {
> >                 close(fd);
> >                 return;
> 
> 
> Adding stable@ since this applies to 4.4.  Any comments?  Thanks!

Ping?  Thanks!

-- 
Tom