linux-kernel - Re: [PATCH] staging: lustre: Fixed the parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6A47AD82-6A8F-44E1-9CB4-C10CF9F9D72E@intel.com>
Date:	Tue, 16 Feb 2016 02:41:43 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	Shalin Mehta <shalinmehta85@...il.com>,
	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"<kernel-janitors@...ts.osdl.org>" <kernel-janitors@...ts.osdl.org>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<lustre-devel@...ts.lustre.org>" <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH] staging: lustre: Fixed the parenthesis

On Feb 15, 2016, at 9:28 PM, Greg KH wrote:

> On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote:
>> The parentehsis are fixed in the macro for the ldlm lock to set and
>> clear the flags.
> 
> "fixed" in what way?  Did you test-build this patch?  Also, you
> mispelled a word here…

The fix in the patch is to make sure number of parenthesis matches, as is
it appears there's one more opening one than the closing.

The original patch that add this had an error somehow, but back then none
of the users were later introduced, so the bug is "hidden" until
first user actually appears.

Compiles work with or without this fix as the result (I also just checked
just to be sure).