linux-kernel - Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <497A8642-BC1A-4EF9-92BC-C3FF3C217BA2@intel.com>
Date:	Tue, 16 Feb 2016 02:51:51 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	Shalin Mehta <shalinmehta85@...il.com>
CC:	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"<kernel-janitors@...ts.osdl.org>" <kernel-janitors@...ts.osdl.org>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<lustre-devel@...ts.lustre.org>" <lustre-devel@...ts.lustre.org>
Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis


On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote:

> The parentehsis are fixed in the macro for the ldlm lock to set and
> clear the flags.
> 
> Signed-off-by: Shalin Mehta <shalinmehta85@...il.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> index 0d3ed87..4f9e9ad 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm_flags.h
> @@ -365,10 +365,10 @@
> #define LDLM_TEST_FLAG(_l, _b)        (((_l)->l_flags & (_b)) != 0)
> 
> /** set a ldlm_lock flag bit */
> -#define LDLM_SET_FLAG(_l, _b)         (((_l)->l_flags |= (_b))
> +#define LDLM_SET_FLAG(_l, _b)         ((_l)->l_flags |= (_b))
> 
> /** clear a ldlm_lock flag bit */
> -#define LDLM_CLEAR_FLAG(_l, _b)       (((_l)->l_flags &= ~(_b))
> +#define LDLM_CLEAR_FLAG(_l, _b)       ((_l)->l_flags &= ~(_b))
> 
> /** Mask of flags inherited from parent lock when doing intents. */
> #define LDLM_INHERIT_FLAGS            LDLM_FL_INHERIT_MASK

Acked-by: Oleg Drokin <oleg.drokin@...el.com>