linux-kernel - Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160217235314.GA13145@deathstar>
Date:	Wed, 17 Feb 2016 17:53:14 -0600
From:	Michael Welling <mwelling@...e.org>
To:	Sricharan <sricharan@...eaurora.org>
Cc:	'Daniel Baluta' <daniel.baluta@...el.com>,
	'Wolfram Sang' <wsa@...-dreams.de>,
	'Jonathan Cameron' <jic23@...nel.org>,
	'Hartmut Knaack' <knaack.h@....de>,
	'Lars-Peter Clausen' <lars@...afoo.de>,
	'Peter Meerwald-Stadler' <pmeerw@...erw.net>,
	'Linux Kernel Mailing List' <linux-kernel@...r.kernel.org>,
	linux-iio@...r.kernel.org,
	'Lucas De Marchi' <lucas.demarchi@...el.com>,
	'Andy Gross' <agross@...eaurora.org>,
	'Pramod Gurav' <pramod.gurav@...rtplayin.com>,
	'Bjorn Andersson' <bjorn.andersson@...ymobile.com>,
	'Guenter Roeck' <linux@...ck-us.net>, eibach@...ys.de,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote:
> On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote:
> > > Hi Sricharan,
> > > 
> > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c
> > > right?
> > >
> >  Yes.
> >  
> > > I'm asking this because this driver doesn't seem to support runtime pm and
> > > there is no check for regmap_write/regmap_write return code in the probe
> > > function.
> >    Hmm to be clear, so it’s the pm_runtime_getsync from i2c-qup which fails right ?
> >    I was tracking that when there are i2c_xfers from pwm. I did not see any failures there.
> >    So wanted to know the correct sequence to reproduce.
> >
> 
> The problem was discovered using the patch that this thread is on. The PWM driver does
> not have the problem.
> 
> When the driver in this patch called pm_runtime_get_sync you got -EINVAL back.

I noticed some patches for the QUP I2C driver in linux-next so I built against it.

The ADC driver now appears to work as desired.

root@...gonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage0_raw 
287
root@...gonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage1_raw 
269
root@...gonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage2_raw 
270
root@...gonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage3_raw 
271

> 
> > Regards,
> >   Sricharan
> >   
> > 
> >