[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160218023622.GA2610@vireshk-i7>
Date: Thu, 18 Feb 2016 08:06:22 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc: Anand Moon <linux.amoon@...il.com>, Kukjin Kim <kgene@...nel.org>,
Lukasz Majewski <l.majewski@...sung.com>,
linux-arm-kernel@...ts.infradead.org,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>,
Linux Kernel <linux-kernel@...r.kernel.org>,
Linux PM list <linux-pm@...r.kernel.org>,
Zhang Rui <rui.zhang@...el.com>,
Eduardo Valentin <edubezval@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high
load
On 18-02-16, 10:47, Krzysztof Kozlowski wrote:
> On 18.02.2016 04:53, Anand Moon wrote:
> > I also got lot's of error.
> >
> > root@...oidxu4l:~# cpu[ 3050.847663] cpu cpu4: Failed to find dev_opp: -19
> > [ 3171.640836] cpu cpu4: device_opp_debug_create_link: Failed to create link
> > [ 3171.646197] cpu cpu4: _add_list_dev: Failed to register opp debugfs (-12)
> > [ 3171.653574] cpu cpu7: device_opp_debug_create_link: Failed to create link
> > [ 3171.659752] cpu cpu7: _add_list_dev: Failed to register opp debugfs (-12)
> > [ 3171.697011] cpu cpu5: cpufreq_init: failed to get clk: -2
> > [ 3171.732505] cpu cpu6: cpufreq_init: failed to get clk: -2
> > [ 3171.768160] cpu cpu7: cpufreq_init: failed to get clk: -2
> >
> > Tested on Odroid-XU4
> >
> > Reviewed-by: Anand Moon <linux.amoon@...il.com>
> > Tested-by: Anand Moon <linux.amoon@...il.com>
What was this Tested-by supposed to mean? You got errors out there ...
> The patch is not sufficient. It does not work the way it should...
>
> BTW, I found the issue. The order of trip points in DT:
> thermal_zone0/trip_point_0_hyst:5000
> thermal_zone0/trip_point_0_temp:50000
> thermal_zone0/trip_point_0_type:active
> thermal_zone0/trip_point_1_hyst:5000
> thermal_zone0/trip_point_1_temp:60000
> thermal_zone0/trip_point_1_type:active
> thermal_zone0/trip_point_2_hyst:5000
> thermal_zone0/trip_point_2_temp:70000
> thermal_zone0/trip_point_2_type:active
> thermal_zone0/trip_point_3_hyst:0
> thermal_zone0/trip_point_3_temp:120000 <---- this should be last one!
> thermal_zone0/trip_point_3_type:critical
> thermal_zone0/trip_point_4_hyst:5000
> thermal_zone0/trip_point_4_temp:90000
> thermal_zone0/trip_point_4_type:passive
> thermal_zone0/trip_point_5_hyst:5000
> thermal_zone0/trip_point_5_temp:110000
> thermal_zone0/trip_point_5_type:passive
>
> After fixing the order in DT, the cpu cooler starts working.
Ahh, nice.
--
viresh
Powered by blists - more mailing lists