linux-kernel - Re: [PATCH] nes: handling failed allocation when creating workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160218045905.GF30450@leon.nu>
Date:	Thu, 18 Feb 2016 06:59:05 +0200
From:	Leon Romanovsky <leon@...n.nu>
To:	Insu Yun <wuninsu@...il.com>
Cc:	faisal.latif@...el.com, dledford@...hat.com, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, taesoo@...ech.edu,
	yeongjin.jang@...ech.edu, insu@...ech.edu, changwoo@...ech.edu
Subject: Re: [PATCH] nes: handling failed allocation when creating workqueue

Please see my minor comments below.
Reviewed-by: Leon Romanovsky <leon@...n.nu>

On Wed, Feb 17, 2016 at 01:06:33PM -0500, Insu Yun wrote:
> Since create_singlethread_workqueue uses kzalloc internally, 
> it can be failed in memory pressure, so need to handle it.

s/can be failed/can fail/

> 
> Signed-off-by: Insu Yun <wuninsu@...il.com>
> ---
>  drivers/infiniband/hw/nes/nes_cm.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
> index cb9f0f2..23afad6 100644
> --- a/drivers/infiniband/hw/nes/nes_cm.c
> +++ b/drivers/infiniband/hw/nes/nes_cm.c
> @@ -2833,7 +2833,7 @@ static struct nes_cm_core *nes_cm_alloc_core(void)
>  	/* alloc top level core control structure */
>  	cm_core = kzalloc(sizeof(*cm_core), GFP_KERNEL);
>  	if (!cm_core)
> -		return NULL;
> +		goto enomem_3;

IMHO, there is no need to define goto label for one return.

>  
>  	INIT_LIST_HEAD(&cm_core->connected_nodes);
>  	init_timer(&cm_core->tcp_timer);
> @@ -2856,12 +2856,23 @@ static struct nes_cm_core *nes_cm_alloc_core(void)
>  
>  	nes_debug(NES_DBG_CM, "Enable QUEUE EVENTS\n");
>  	cm_core->event_wq = create_singlethread_workqueue("nesewq");
> +	if (!cm_core->event_wq)
> +		goto enomem_2;
>  	cm_core->post_event = nes_cm_post_event;
>  	nes_debug(NES_DBG_CM, "Enable QUEUE DISCONNECTS\n");
>  	cm_core->disconn_wq = create_singlethread_workqueue("nesdwq");
> +	if (!cm_core->disconn_wq)
> +		goto enomem_1;
>  
>  	print_core(cm_core);
>  	return cm_core;
> +
> +enomem_1:
> +	destroy_workqueue(cm_core->event_wq);
> +enomem_2:
> +	kfree(cm_core);
> +enomem_3:
> +	return NULL;
>  }
>  
>  
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html