linux-kernel - Re: [PATCH v5] portman2x4 - use new parport device model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160218103747.GA12223@sudip-pc>
Date:	Thu, 18 Feb 2016 16:07:59 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] portman2x4 - use new parport device model

On Thu, Feb 18, 2016 at 11:20:28AM +0100, Takashi Iwai wrote:
> On Wed, 17 Feb 2016 13:56:27 +0100,
> Sudip Mukherjee wrote:
> > 
> > Modify portman driver to use the new parallel port device model.
> > The advantage of using the device model is that the device gets binded
> > to the hardware, we get the feature of hotplug, we can bind/unbind
> > the driver at runtime.
> > The changes are in the way the driver gets registered with the
> > parallel port subsystem and the temporary device to probe portman card
> > is removed and portman_probe() is used in the probe callback.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
> > 
> > v5: claimed flag and one call to parport_claim() removed.
> > v4: temporary device to probe is removed.
> > v3: changed commit message
> > v2:
> >  1. pardev_cb is initialized while declaring, thus removing the use of
> >  memset.
> >  2. used pdev->id.
> >  3. v1 did not have the parport probe callback, but we will need the
> >  probe callback for binding as the name of the driver and the name of
> >  the device is different.
> >  4. in v1 I missed modifying snd_portman_probe_port().
> 
> OK, I merged this one to for-next branch now.  Let's cross fingers :)

Thanks.
Its simple change, nothing should happen.
I will send you the other one in few days time if 0day does not report
anything on this patch.

regards
sudip