linux-kernel - Re: [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160218133608.GC28860@pd.tnic>
Date:	Thu, 18 Feb 2016 14:36:08 +0100
From:	Borislav Petkov <bp@...e.de>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Andy Lutomirski <luto@...nel.org>,
	Alexander Popov <alpopov@...ecurity.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/head64: no need to define early_idt_ripmsg only
 if CONFIG_KALLSYMS=n

On Thu, Feb 18, 2016 at 01:58:15PM +0600, Alexander Kuleshov wrote:
> We have definition of the early_idt_ripmsg which represents string header
> for the output of the kernel symbols during early exception. But the
> header with kernel symbols will be printed in a case if the CONFIG_KALLSYMS=y.

And this is a problem because... ?

Also, try to search how many distros and configs enable KALLSYMS. That
might clear some uncertainties when deciding to add one more ifdef to an
already hard to read code.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--