lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 09:10:20 -0600 From: atull <atull@...nsource.altera.com> To: Moritz Fischer <moritz.fischer@...us.com> CC: Pantelis Antoniou <pantelis.antoniou@...sulko.com>, Rob Herring <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, Grant Likely <grant.likely@...aro.org>, Devicetree List <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Pantelis Antoniou <pantelis.antoniou@...il.com>, Alan Tull <delicious.quinoa@...il.com>, "Dinh Nguyen" <dinguyen@...nsource.altera.com> Subject: Re: [PATCH 1/1] of/overlay: of overlay callbacks On Thu, 18 Feb 2016, Moritz Fischer wrote: > Hi Alan, > > a couple of nits below. > > On Wed, Feb 17, 2016 at 9:41 AM, Alan Tull <atull@...nsource.altera.com> wrote: > > > > > +/* > > + * Send overlay callbacks to handlers that match. This call is blocking. In > Can we make this 'Invoke' instead of send? > > > @@ -370,6 +448,13 @@ int of_overlay_create(struct device_node *tree) > > goto err_free_idr; > > } > > > > + err = send_overlay_callbacks(ov, OF_OVERLAY_PRE_APPLY); > > Again ... maybe invoke ;-) Hi Moritz, Yes, that's better. I'll make the sends to be invokes. > > > diff --git a/include/linux/of.h b/include/linux/of.h > > index dc6e396..def9481 100644 > > --- a/include/linux/of.h > > +++ b/include/linux/of.h > > @@ -101,9 +101,33 @@ static inline int of_node_is_attached(struct device_node *node) > > return node && node->kobj.state_in_sysfs; > > } > > > > +/* Callback types */ > > +#define OF_OVERLAY_PRE_APPLY (0) > > +#define OF_OVERLAY_POST_APPLY (1) > > +#define OF_OVERLAY_PRE_REMOVE (2) > > +#define OF_OVERLAY_POST_REMOVE (3) > > Can we make this an enum? Yes. And I can move it from of.h to overlay.c. Thanks for the nits! Alan > > Cheers, > > Moritz >
Powered by blists - more mailing lists