| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1455816110-2799-1-git-send-email-linux.amoon@gmail.com> Date: Thu, 18 Feb 2016 22:51:50 +0530 From: Anand Moon <linux.amoon@...il.com> To: Vinod Koul <vinod.koul@...el.com>, Dan Williams <dan.j.williams@...el.com>, Anand Moon <linux.amoon@...il.com> Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] dmaengine: pl330: initialize tasklet after spin_unlock_irqrestore From: Anand Moon <linux.amoon@...il.com> pl330_tasklet tasklet uses the same spinlock pch->lock for safe IRQ locking. It's safe to initialize pl330_tasklet tasklet after release of the locking. Signed-off-by: Anand Moon <linux.amoon@...il.com> --- drivers/dma/pl330.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 17ee758..df2cab1 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2091,10 +2091,10 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan) return -ENOMEM; } - tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch); - spin_unlock_irqrestore(&pch->lock, flags); + tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch); + return 1; } -- 1.9.1
Powered by blists - more mailing lists