lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 23:10:02 +0530 From: Anand Moon <linux.amoon@...il.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.com>, Anand Moon <linux.amoon@...il.com> Cc: linux-serial@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] serial: samsung: fix the inconsistency in spinlock From: Anand Moon <linux.amoon@...il.com> changes fix the correct order of the spin_lock_irqrestore/save. Signed-off-by: Anand Moon <linux.amoon@...il.com> --- drivers/tty/serial/samsung.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index d72cd73..96fe14d 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -759,9 +759,9 @@ static irqreturn_t s3c24xx_serial_tx_chars(int irq, void *id) } if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS) { - spin_unlock(&port->lock); + spin_unlock_irqrestore(&port->lock, flags); uart_write_wakeup(port); - spin_lock(&port->lock); + spin_lock_irqsave(&port->lock, flags); } if (uart_circ_empty(xmit)) -- 1.9.1
Powered by blists - more mailing lists