linux-kernel - Re: [PATCH v7 2/3] clk: clk-pic32: Add PIC32 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160219201615.2278.2909@quark.deferred.io>
Date:	Fri, 19 Feb 2016 12:16:15 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	Joshua Henderson <joshua.henderson@...rochip.com>,
	linux-kernel@...r.kernel.org
Cc:	linux-mips@...ux-mips.org, ralf@...ux-mips.org,
	"Purna Chandra Mandal" <purna.mandal@...rochip.com>,
	"Joshua Henderson" <joshua.henderson@...rochip.com>,
	"Stephen Boyd" <sboyd@...eaurora.org>, linux-clk@...r.kernel.org
Subject: Re: [PATCH v7 2/3] clk: clk-pic32: Add PIC32 clock driver

Quoting Joshua Henderson (2016-02-19 08:25:35)
> +const struct clk_ops pic32_roclk_ops = {
> +       .enable                 = roclk_enable,
> +       .disable                = roclk_disable,
> +       .is_enabled             = roclk_is_enabled,
> +       .get_parent             = roclk_get_parent,
> +       .set_parent             = roclk_set_parent,
> +       .determine_rate         = roclk_determine_rate,
> +       .recalc_rate            = roclk_recalc_rate,
> +       .round_rate             = roclk_round_rate,
> +       .set_rate_and_parent    = roclk_set_rate_and_parent,
> +       .set_rate               = roclk_set_rate,
> +       .init                   = roclk_init,
> +};

You can remove .round_rate and only use .determine_rate.

...
> +CLK_OF_DECLARE(pic32mzda_clk, "microchip,pic32mzda-clk", pic32mzda_clock_init);

Can you make this a platform_driver instead of using CLK_OF_DECLARE? I
asked this in v6 but there was no response.

Regards,
Mike

> -- 
> 1.7.9.5
>