linux-kernel - Re: [PATCH 0/3] LightNVM patches for next 4.5-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56C7E006.40600@kernel.dk>
Date:	Fri, 19 Feb 2016 20:39:50 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Matias Bjørling <m@...rling.me>
Cc:	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] LightNVM patches for next 4.5-rc

On 02/19/2016 12:15 PM, Jens Axboe wrote:
> On Fri, Feb 19 2016, Matias Bjørling wrote:
>> Hi Jens,
>>
>> Here is a couple of patches for the next 4.5-rc.
>>
>> A patch from Alan that fixes up logic in nvm_configure_get. Another
>> patch from Javier that fixes a bug with multiple luns in RRPC, and at
>> last a patch from me that fixes the get bad block interface when
>> multiple planes are available on the media.
>
> Applied, but you need to update your patch base, patch #3 needed to be
> hand applied because your repo does not have the below applied.
>
> commit ff0e498bfa185fad5e86c4c7a2db4f9648d2344f
> Author: Javier González <jg@...htnvm.io>
> Date:   Tue Jan 12 07:49:33 2016 +0100
>
>      lightnvm: manage open and closed blocks separately

And even after that, it's broken:

drivers/lightnvm/rrpc.c: In function ‘rrpc_l2p_update’:
drivers/lightnvm/rrpc.c:1047:24: error: ‘struct rrpc’ has no member 
named ‘nr_sects’
    div_u64_rem(pba, rrpc->nr_sects, &mod);
                         ^
I've dropped that patch. You need to step it up, that's way too lax for 
something destined for the current series at -rc4 time.

-- 
Jens Axboe