linux-kernel - Re: [PATCH] firmware: set firmware_buf size in fw_get_filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVMjr8XCOdjB3Y+wCTgf2zK_5WZoc3Rsc018z_zF-_2M7w@mail.gmail.com>
Date:	Sun, 21 Feb 2016 17:46:40 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kees Cook <keescook@...omium.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware()

On Sat, Feb 20, 2016 at 5:22 PM, Sergey Senozhatsky
<sergey.senozhatsky@...il.com> wrote:
> Set firmware_buf->size in fw_get_filesystem_firmware() after
> successful kernel_read_file_from_path(), otherwise assign_firmware_buf()
> fails.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

Acked-by: Ming Lei <ming.lei@...onical.com>

This patch fixes d29a7309971afb97b21e7(firmware: replace call
to fw_read_file_contents() with kernel version).

thanks,

> ---
>  drivers/base/firmware_class.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index b8bc846..7cf41a5 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -335,6 +335,7 @@ static int fw_get_filesystem_firmware(struct device *device,
>                 }
>                 dev_dbg(device, "direct-loading %s\n",
>                         buf->fw_id);
> +               buf->size = size;
>                 fw_finish_direct_load(device, buf);
>                 break;
>         }
> --
> 2.7.1
>