linux-kernel - Re: [PATCH 06/54] perf tools: Add API to config maps in bpf object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CA8910.7000303@huawei.com>
Date:	Mon, 22 Feb 2016 12:05:36 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Alexei Starovoitov <ast@...nel.org>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Cody P Schafer" <dev@...yps.com>,
	"David S. Miller" <davem@...emloft.net>,
	He Kuang <hekuang@...wei.com>,
	Jérémie Galarneau 
	<jeremie.galarneau@...icios.com>, Jiri Olsa <jolsa@...nel.org>,
	"Kirill Smelkov" <kirr@...edi.com>, Li Zefan <lizefan@...wei.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	"Peter Zijlstra" <peterz@...radead.org>, <pi3orama@....com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/54] perf tools: Add API to config maps in bpf object



On 2016/2/19 21:53, Arnaldo Carvalho de Melo wrote:
> Sorry for the top post, but the message below didn't made it thru due to
> local problems as I recently switched notebooks, my postfix setup barfed
> this one :-\
>
> This is what I have in my tmp.perf/bpf_map:
>
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/bpf_map&id=5c78fe3c5a944ba7f9a85f59548295211f3d252c
>
> Please take a look and see if you're ok with it,

I agree your change, but the commit you mentioned has a bug
which I have already fixed in Feb. 19 patch set:

At bpf_map__config_value:

+        if (!term->type_val == PARSE_EVENTS__TERM_TYPE_NUM) {
+                pr_debug("ERROR: wrong value type\n");
+                return -BPF_LOADER_ERRNO__OBJCONF_MAP_VALUE;
+        }

Should use

          if (term->type_val != PARSE_EVENTS__TERM_TYPE_NUM)

I'll switch 'maps' to 'map' as you did in my tree and send this
patch again. (still based on perf/core, so I can solve potential
conflicts in my side).

Thank you.