linux-kernel - Re: [Resend PATCH 3/3] scsi:stex.c Add S3/S4 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56CA74A9.6040906@gmail.com>
Date:	Mon, 22 Feb 2016 10:38:33 +0800
From:	Charles Chiou <ch1102chiou@...il.com>
To:	Oliver Neukum <oneukum@...e.com>
CC:	Johannes Thumshirn <jthumshirn@...e.de>,
	Christoph Hellwig <hch@...radead.org>,
	JBottomley@...allels.com, grace.chang@...promise.com,
	linus.chen@...promise.com, victor.p@...mise.com,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	eva.cheng@...promise.com
Subject: Re: [Resend PATCH 3/3] scsi:stex.c Add S3/S4 support

Hi Oliver,
sure, we'll fix it at the next patch version. Thank you.
Charles

On 02/04/2016 07:37 PM, Oliver Neukum wrote:
> On Thu, 2016-02-04 at 19:22 +0800, Charles Chiou wrote:
>> +static int stex_choice_sleep_mic(pm_message_t state)
>> +{
>> +    switch (state.event) {
>> +    case PM_EVENT_SUSPEND:
>> +        return ST_S3;
>> +    case PM_EVENT_FREEZE:
>
> Why do you react to PM_EVENT_FREEZE at all?
> That is too early. You will get a HIBERNATE
> event anyway. If the write out fails you are
> in trouble if you already reacted to
> PM_EVENT_FREEZE
>
> 	Regards
> 		Oliver
>
>