linux-kernel - Re: [v9,4/5] iommu/mediatek: Add mt8173 IOMMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1456080189.25237.4.camel@mhfsdcap03>
Date:	Mon, 22 Feb 2016 02:43:09 +0800
From:	Yong Wu <yong.wu@...iatek.com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Joerg Roedel <joro@...tes.org>,
	Thierry Reding <treding@...dia.com>,
	Mark Rutland <mark.rutland@....com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	<p.zabel@...gutronix.de>, <devicetree@...r.kernel.org>,
	<pebolle@...cali.nl>, <kendrick.hsu@...iatek.com>,
	<mitchelh@...eaurora.org>, <arnd@...db.de>,
	<srv_heupstream@...iatek.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	<linux-kernel@...r.kernel.org>, Tomasz Figa <tfiga@...gle.com>,
	<iommu@...ts.linux-foundation.org>,
	Rob Herring <robh+dt@...nel.org>,
	Daniel Kurtz <djkurtz@...gle.com>,
	Sasha Hauer <kernel@...gutronix.de>,
	<linux-mediatek@...ts.infradead.org>, <youhua.li@...iatek.com>,
	Robin Murphy <robin.murphy@....com>,
	<linux-arm-kernel@...ts.infradead.org>,
	Lucas Stach <l.stach@...gutronix.de>, <djkurtz@...omium.org>
Subject: Re: [v9,4/5] iommu/mediatek: Add mt8173 IOMMU driver

On Fri, 2016-02-19 at 23:02 -0800, Guenter Roeck wrote:
> On Wed, Feb 17, 2016 at 08:46:13AM +0800, Yong Wu wrote:
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
[...]
> > +#include <linux/clk.h>
> > +#include <linux/component.h>
> > +#include <linux/dma-iommu.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/io.h>
> > +#include <linux/iommu.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/list.h>
> > +#include <linux/module.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_iommu.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/of_platform.h>
> > +#include <linux/platform_device.h>
> > +#include <soc/mediatek/smi.h>
> > +#include <dt-bindings/memory/mt8173-larb-port.h>
> > +
> 
> Some missing includes:
> 
> linux/bug.h
> 	for WARN_ON()
> linux/device.h
> 	for dev_xxx() error messages, dev_get_drvdata(), etc.
> linux/err.h
> 	for error functions (IS_ERR, error definitions)
> linux/slab.h
> 	for kzalloc() etc.
> linux/spinlock.h
> 	for spinlock functions
> asm/barrier.h
> 	for wmb()
> 
> Guenter

Hi Guenter,
    Thanks for this suggestion. I'm sorry that I didn't get any build
warning or error here. Anyway I will add them and send a quick v10.