linux-kernel - Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oab8wyfe.fsf@belgarion.home>
Date:	Mon, 22 Feb 2016 16:35:17 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Sergei Ianovich <ynvich@...il.com>
Cc:	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org (moderated list:PXA2xx/PXA3xx
	SUPPORT),
	devicetree@...r.kernel.org (open list:OPEN FIRMWARE AND FLATTENED
	DEVICE TREE BINDINGS)
Subject: Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb

Sergei Ianovich <ynvich@...il.com> writes:

> Without this patch I am getting an error:
> ---8<---
> [   15.709742] ohci-pxa27x: OHCI PXA27x/PXA3x driver
> [   15.737150] pxa27x-ohci: probe of 4c000000.ohci failed with error -2
> ---8<---
>
> The error is generated in drivers/usb/host/ohci-pxa27x.c at line 441:
> ---8<---
> 441:	usb_clk = devm_clk_get(&pdev->dev, NULL);
> 442:	if (IS_ERR(usb_clk))
> 443:		return PTR_ERR(usb_clk);
> ---8<---
>
> The error is caused by different names for the same DT node in pxa2xx.dtsi
> and pxa27x.dtsi.
>
> Signed-off-by: Sergei Ianovich <ynvich@...il.com>
> CC: Robert Jarzmik <robert.jarzmik@...e.fr>
Hi Sergei,

You're right, I haven't seen the pxa2xx.dtsi statement before.

As such, could you amend a bit your patch please to :
 - add:
Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
 - make the same change in pxa3xx.dtsi, as the same error is there
 - and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.dtsi
 - remove the compatible, reg, interrupts and status from both pxa27x.dtsi and
   pxa3xx.dtsi as they are redundant with the included pxa2xxx.dsti one

I'm even wondering if the proper change wouldn't be to scrap the ohci
declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clocks"
property to pxa2xx.dtsi ...

Cheers.

--
Robert