linux-kernel - Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456228901.23036.9.camel@gmail.com>
Date:	Tue, 23 Feb 2016 15:01:41 +0300
From:	Sergei Ianovich <ynvich@...il.com>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	"moderated list:PXA2xx/PXA3xx SUPPORT" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb

Hi Robert, 

On Mon, 2016-02-22 at 16:35 +0100, Robert Jarzmik wrote:
> You're right, I haven't seen the pxa2xx.dtsi statement before.
> 
> As such, could you amend a bit your patch please to :
>  - add:
> Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
>  - make the same change in pxa3xx.dtsi, as the same error is there
>  - and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.dtsi
>  - remove the compatible, reg, interrupts and status from both pxa27x.dtsi and
>    pxa3xx.dtsi as they are redundant with the included pxa2xxx.dsti one

No problem. Let's figure out the best approach.

> I'm even wondering if the proper change wouldn't be to scrap the ohci
> declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clocks"
> property to pxa2xx.dtsi ...

Since clocks are declared in pxa27x.dtsi and pxa3xx.dtsi, there is a
stronger ground to have node clocks properties set in pxa27x.dtsi
and pxa3xx.dtsi as well. However, there is already nodes with clocks
properties in pxa2xx.dtsi.

I cannot choose, you should make a decision.


-- 
Sergei Ianovich <ynvich@...il.com>