linux-kernel - [REGRESSION] dell-wmi, dell-laptop: select DMI, Kconfig recursive dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160223162940.GA28373@hudson.localdomain>
Date:	Tue, 23 Feb 2016 08:29:40 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Andy Lutomirski <luto@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Rohár <pali.rohar@...il.com>,
	Darren Hart <dvhart@...ux.intel.com>
Subject: [REGRESSION] dell-wmi, dell-laptop: select DMI, Kconfig recursive
 dependency

Hi Andy,

Running the latest linux-next I am getting a Kconfig recursive
dependency detected message that was not present before.

  jeri@...son:~/linux-next$ make oldconfig
  scripts/kconfig/conf  --oldconfig Kconfig
  drivers/gpio/Kconfig:34:error: recursive dependency detected!
  For a resolution refer to Documentation/kbuild/kconfig-language.txt
  subsection "Kconfig recursive dependency limitations"
  drivers/gpio/Kconfig:34:	symbol GPIOLIB is selected by GEOS
  For a resolution refer to Documentation/kbuild/kconfig-language.txt
  subsection "Kconfig recursive dependency limitations"
  arch/x86/Kconfig:2572:	symbol GEOS depends on DMI
  For a resolution refer to Documentation/kbuild/kconfig-language.txt
  subsection "Kconfig recursive dependency limitations"
  arch/x86/Kconfig:810:	symbol DMI is selected by DELL_LAPTOP
  For a resolution refer to Documentation/kbuild/kconfig-language.txt
  subsection "Kconfig recursive dependency limitations"
  drivers/platform/x86/Kconfig:104:	symbol DELL_LAPTOP depends on BACKLIGHT_CLASS_DEVICE
  For a resolution refer to Documentation/kbuild/kconfig-language.txt
  subsection "Kconfig recursive dependency limitations"
  drivers/video/backlight/Kconfig:158:	symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHT
  For a resolution refer to Documentation/kbuild/kconfig-language.txt
  subsection "Kconfig recursive dependency limitations"
  drivers/video/fbdev/Kconfig:192:	symbol FB_BACKLIGHT is selected by FB_SSD1307
  For a resolution refer to Documentation/kbuild/kconfig-language.txt
  subsection "Kconfig recursive dependency limitations"
  drivers/video/fbdev/Kconfig:2463:	symbol FB_SSD1307 depends on GPIOLIB
  #
  # configuration written to .config
  #

I traced the problem to patch cbd9d95b2b27e0678 which added
'select DMI' to drivers/platform/x86/Kconfig.

  From cbd9d95b2b27e0678a1868eb37b5cff1b0456ac4 Mon Sep 17 00:00:00 2001
  From: Andy Lutomirski <luto@...nel.org>
  Date: Mon, 15 Feb 2016 08:32:34 -0800
  Subject: [PATCH 3/3] dell-wmi, dell-laptop: select DMI
  MIME-Version: 1.0
  Content-Type: text/plain; charset=UTF-8
  Content-Transfer-Encoding: 8bit

  dell-wmi and dell-laptop will compile but won't work right if DMI
  isn't selected.

  Signed-off-by: Andy Lutomirski <luto@...nel.org>
  Acked-by: Pali Rohár <pali.rohar@...il.com>
  Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
  ---
   drivers/platform/x86/Kconfig | 2 ++
   1 file changed, 2 insertions(+)

  diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
  index 3e4d9c3..659e13b 100644
  --- a/drivers/platform/x86/Kconfig
  +++ b/drivers/platform/x86/Kconfig
  @@ -112,6 +112,7 @@ config DELL_LAPTOP
   	select POWER_SUPPLY
   	select LEDS_CLASS
   	select NEW_LEDS
  +	select DMI
   	default n
   	---help---
   	This driver adds support for rfkill and backlight control to Dell
  @@ -123,6 +124,7 @@ config DELL_WMI
   	depends on INPUT
   	depends on ACPI_VIDEO || ACPI_VIDEO = n
   	select INPUT_SPARSEKMAP
  +	select DMI
   	---help---
   	  Say Y here if you want to support WMI-based hotkeys on Dell laptops.

  -- 
  2.7.0

I have also attached my .config in case that is useful.

-- 
- Jeremiah Mahler

View attachment ".config" of type "text/plain" (119847 bytes)