linux-kernel - Re: [PATCH 46/61] gpio: tegra: Use devm_gpiochip_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160223163047.GB13755@ulmo.nvidia.com>
Date:	Tue, 23 Feb 2016 17:30:47 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	linus.walleij@...aro.org, gnurou@...il.com,
	michael.hennerich@...log.com, corbet@....net, albeu@...e.fr,
	rjui@...adcom.com, shc_work@...l.ru,
	support.opensource@...semi.com, swarren@...dotorg.org,
	bjorn.andersson@...ymobile.com, a.kesavan@...sung.com,
	gregkh@...uxfoundation.org, catalin.marinas@....com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, patches@...nsource.wolfsonmicro.com,
	bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 46/61] gpio: tegra: Use devm_gpiochip_add_data() for gpio
 registration

On Mon, Feb 22, 2016 at 07:38:35PM +0530, Laxman Dewangan wrote:
> Use devm_gpiochip_add_data() for GPIO registration.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> ---
>  drivers/gpio/gpio-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 9a1a7e2..790bb11 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -545,7 +545,7 @@ static int tegra_gpio_probe(struct platform_device *pdev)
>  
>  	tegra_gpio_chip.of_node = pdev->dev.of_node;
>  
> -	ret = gpiochip_add_data(&tegra_gpio_chip, NULL);
> +	ret = devm_gpiochip_add_data(&pdev->dev, &tegra_gpio_chip, NULL);
>  	if (ret < 0) {
>  		irq_domain_remove(irq_domain);
>  		return ret;

It's slightly redundant to do this because the driver probe will never
fail after this point and the driver can't be unloaded, so there's no
way that the GPIO chip would ever be removed.

But in the interest of consistency I have no objections to doing this.
It might also happen that, eventually, we might turn this into a proper
driver, at which point this would come in useful.

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)