linux-kernel - Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ToGPGfXoS7rBr6RKPVxgRemj35LwfY4o9JHiZKkwrxOTsMww@mail.gmail.com>
Date:	Tue, 23 Feb 2016 13:34:39 -0300
From:	Diego Viola <diego.viola@...il.com>
To:	cooldavid@...ldavid.org
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	richard.weinberger@...il.com, pavel@....cz, rjw@...ysocki.net,
	davem@...emloft.net, valdis.kletnieks@...edu,
	Diego Viola <diego.viola@...il.com>
Subject: Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

On Tue, Feb 23, 2016 at 12:04 PM, Diego Viola <diego.viola@...il.com> wrote:
> The JMC260 network card fails to suspend/resume because the call to
> jme_start_irq() was too early, moving the call to jme_start_irq() after
> the call to jme_reset_link() makes it work.
>
> Prior this change suspend/resume would fail unless /sys/power/pm_async=0
> was explicitly specified.
>
> Relevant bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351
>
> Signed-off-by: Diego Viola <diego.viola@...il.com>
> ---
>  drivers/net/ethernet/jme.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
> index b1de7af..8adbe8f 100644
> --- a/drivers/net/ethernet/jme.c
> +++ b/drivers/net/ethernet/jme.c
> @@ -3312,13 +3312,14 @@ jme_resume(struct device *dev)
>                 jme_reset_phy_processor(jme);
>         jme_phy_calibration(jme);
>         jme_phy_setEA(jme);
> -       jme_start_irq(jme);
>         netif_device_attach(netdev);
>
>         atomic_inc(&jme->link_changing);
>
>         jme_reset_link(jme);
>
> +       jme_start_irq(jme);
> +
>         return 0;
>  }
>
> --
> 2.7.1
>

I've sent this v3 patch and I think it's better than v2 and v1, as it
includes the link to my bug report and the description is better.

Diego