linux-kernel - Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CDF049.4080502@amd.com>
Date:	Wed, 24 Feb 2016 12:02:49 -0600
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<tony.luck@...el.com>, <hpa@...or.com>, <mingo@...hat.com>,
	<tglx@...utronix.de>, <dougthompson@...ssion.com>,
	<mchehab@....samsung.com>, <x86@...nel.org>,
	<linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<ashok.raj@...el.com>, <gong.chen@...ux.intel.com>,
	<len.brown@...el.com>, <peterz@...radead.org>,
	<ak@...ux.intel.com>, <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

On 2/24/2016 5:33 AM, Borislav Petkov wrote:
> On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote:
>> I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well.
>> So might be better to retain it here.
> Actually, I'm thinking, these all are - even if used in multiple files
> - all MCE-specific and therefore used in MCE/RAS-specific code. So they
> all should go into mce.h. Everything RAS includes that header so they're
> perfectly fine there...

Hmm. We introduced MSR_AMD64_SMCA_MCx_CONFIG in this patch-
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e6c8f1873be8a14c7e44202df1f7e6ea61bf3352

Should I change that as well and move it to mce.h?

>> (It comes up to 81 chars, but will ignore checkpatch in this case..)
> The 80-cols rule is not a hard one. Here's some food for thought:
>
> https://lkml.kernel.org/r/20160219095132.GA9681@gmail.com
>

Got it.

Thanks,
-Aravind.