linux-kernel - Re: [PATCH][V3] mt7601u: do not free dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <286FE43B-A725-4BE0-B490-E91A107F8D0B@wp.pl>
Date:	Thu, 25 Feb 2016 18:36:31 -0500
From:	Kuba Kicinski <kubakici@...pl>
To:	Colin King <colin.king@...onical.com>,
	Kalle Valo <kvalo@...eaurora.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

On 25 February 2016 18:24:27 GMT-05:00, Colin King <colin.king@...onical.com> wrote:
>From: Colin Ian King <colin.king@...onical.com>
>
>If the allocation of ivp fails the error handling attempts to
>free an uninitialized dma_buf; this data structure just contains
>garbage on the stack, so the freeing will cause issues when the
>urb, buf and dma fields are free'd. Fix this by not free'ing the
>dma_buf if the ivp allocation fails.
>
>Signed-off-by: Colin Ian King <colin.king@...onical.com>

LGTM, thanks.