linux-kernel - Re: [V3] mt7601u: do not free dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160307123954.A86A06067A@smtp.codeaurora.org>
Date:	Mon,  7 Mar 2016 12:39:54 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Colin Ian King <colin.king@...onical.com>
Cc:	Jakub Kicinski <kubakici@...pl>,
	Matthias Brugger <matthias.bgg@...il.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [V3] mt7601u: do not free dma_buf when ivp allocation fails


> From: Colin Ian King <colin.king@...onical.com>
> 
> If the allocation of ivp fails the error handling attempts to
> free an uninitialized dma_buf; this data structure just contains
> garbage on the stack, so the freeing will cause issues when the
> urb, buf and dma fields are free'd. Fix this by not free'ing the
> dma_buf if the ivp allocation fails.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Reviewed-by: Julian Calaby <julian.calaby@...il.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo