linux-kernel - Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1456402534.25534.27.camel@gmail.com>
Date:	Thu, 25 Feb 2016 20:15:34 +0800
From:	Chen Yucong <slaoub@...il.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info()

On Thu, 2016-02-25 at 09:22 +0100, Ingo Molnar wrote:
> * Chen Yucong <slaoub@...il.com> wrote:
> 
> > arch/x86/* use a mixture of printk(KERN_INFO ) and pr_info().
> > This patch converts all of printk(KERN_INFO ) to pr_info() for
> > arch/x86 directory.
> > 
> > Signed-off-by: Chen Yucong <slaoub@...il.com>
> 
> >  85 files changed, 332 insertions(+), 394 deletions(-)
> 
> So what this changelog is missing is how it was ensured that the printk output did 
> not change.
> 
 The previously committed patch was applied to a particular directory.
This involved all printk(KERN_<LEVEL>), including `ugly` pr_debug().

However this patch are only related to printk(KERN_INFO ...), pr_info()
is less dangerous than pr_debug(). The macro body of pr_info() is
simple and definite, without any conditional options.

An theme to notice: this patch also refers to only a few pr_err(), and
if it is feasible, the next patch will covert all printk(KERN_ERR ) to
pr_err(). This might be a less risky way for conversion.

thx!
   cyc