linux-kernel - [report] invalid error code in do_register_con

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160225213409.GD18267@mwanda>
Date:	Fri, 26 Feb 2016 00:34:09 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jiri Slaby <jslaby@...e.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [report] invalid error code in do_register_con_driver() console

Hi Jiri,

I'm getting the following static checker warning:

	drivers/tty/vt/vt.c:3588 do_register_con_driver()
	warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0'

drivers/tty/vt/vt.c
  3582          if (retval)
  3583                  goto err;
  3584  
  3585          desc = csw->con_startup();
  3586  
  3587          if (!desc)
  3588                  goto err;
  3589  
  3590          retval = -EINVAL;
  3591  

Probably, we could more the "retval = -EINVAL;" before the goto?  I
don't think it's intentional?

regards,
dan carpenter