linux-kernel - Re: [report] invalid error code in do_register_con

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5728B4FB.8090208@suse.cz>
Date:	Tue, 3 May 2016 16:26:03 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [report] invalid error code in do_register_con_driver() console

On 02/25/2016, 10:34 PM, Dan Carpenter wrote:
> Hi Jiri,
> 
> I'm getting the following static checker warning:
> 
> 	drivers/tty/vt/vt.c:3588 do_register_con_driver()
> 	warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0'
> 
> drivers/tty/vt/vt.c
>   3582          if (retval)
>   3583                  goto err;
>   3584  
>   3585          desc = csw->con_startup();
>   3586  
>   3587          if (!desc)
>   3588                  goto err;
>   3589  
>   3590          retval = -EINVAL;
>   3591  
> 
> Probably, we could more the "retval = -EINVAL;" before the goto?  I
> don't think it's intentional?

Yes, you are right. I've prepared a fix to send out.

thanks,
-- 
js
suse labs