linux-kernel - Re: [PATCH] net: ezchip: adapt driver to little endian architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24793363.yg41IbJKTo@wuerfel>
Date:	Fri, 26 Feb 2016 21:10:31 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Lada Trimasova <Lada.Trimasova@...opsys.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
	Noam Camus <noamc@...hip.com>, Tal Zilcer <talz@...hip.com>
Subject: Re: [PATCH] net: ezchip: adapt driver to little endian architecture

On Friday 26 February 2016 22:05:09 Lada Trimasova wrote:
>                 for (i = 0; i < len; i++, reg++) {
>                         u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF);
> +                       buf = be32_to_cpu(buf);
>                         put_unaligned(buf, reg);
>                 }

I think most of the changes can make use of the put_unaligned_be32()
etc helpers that might also be more efficient.

	Arnd