linux-kernel - Re: [PATCH] bsp: add SoC device to brcmstb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 14:58:15 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Justin Chen <justinpopo6@...il.com>, linux-kernel@...r.kernel.org,
	f.fainelli@...il.com, sbranden@...adcom.com, rjui@...adcom.com,
	Justin Chen <justin.chen@...adcom.com>,
	bcm-kernel-feedback-list@...adcom.com, gregory.0xf0@...il.com,
	computersforpeace@...il.com
Subject: Re: [PATCH] bsp: add SoC device to brcmstb

On Thursday 25 February 2016 16:19:07 Justin Chen wrote:
>   */
>  void brcmstb_biuctrl_init(void);
>  
> +/*
> + * Helper functions for getting family or product id from the
> + * SoC driver.
> + */
> +u32 brcmstb_get_family_id(void);
> +u32 brcmstb_get_product_id(void);
> +
>  #endif /* __BRCMSTB_SOC_H */
> -- 

Please remove the declarations from the header file and make the
variable local to this file, to make sure no other driver accidentally
accesses them.

	Arnd