linux-kernel - Re: [PATCH 2/2] crypto: remove padding logic from rsa.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21318.1456495221@warthog.procyon.org.uk>
Date:	Fri, 26 Feb 2016 14:00:21 +0000
From:	David Howells <dhowells@...hat.com>
To:	Tadeusz Struk <tadeusz.struk@...el.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	balrogg@...glemail.com, linux-security-module@...r.kernel.org,
	keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
	zohar@...ux.vnet.ibm.com
Subject: Re: [PATCH 2/2] crypto: remove padding logic from rsa.c

Tadeusz Struk <tadeusz.struk@...el.com> wrote:

> +		if (memcmp(sig->digest, output, sig->digest_size) ||

I've added " != 0" after the memcmp().

> +		    req->dst_len != sig->digest_size)
> +			ret = -EBADMSG;

Btw, this has to be -EKEYREJECTED; -EBADMSG would indicate that the container
is unparseable.  I wonder if we should propose a -ESIGREJECTED error...

David