linux-kernel - Re: [PATCH v7] x86/setup: get ramdisk parameters only once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160227115546.GC16200@gmail.com>
Date:	Sat, 27 Feb 2016 12:55:46 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...e.de>
Cc:	Alexander Kuleshov <kuleshovmail@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Joerg Roedel <jroedel@...e.de>, Dave Young <dyoung@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Baoquan He <bhe@...hat.com>, Mark Salter <msalter@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] x86/setup: get ramdisk parameters only once


* Borislav Petkov <bp@...e.de> wrote:

> >  void __init setup_arch(char **cmdline_p)
> >  {
> > +	struct ramdisk ramdisk = {
> > +		.start_addr = get_ramdisk_image(),
> > +		.size  = PAGE_ALIGN(get_ramdisk_size()),
> > +		.reserve_ramdisk = true
> > +	};
> 
> More readable:
> 
>         struct ramdisk ramdisk = {
>                 .start_addr	 = get_ramdisk_image(),
>                 .size		 = PAGE_ALIGN(get_ramdisk_size()),
>                 .reserve_ramdisk = true,
>         };

So I find it highly annoying that this review feedback was done by Boris, but not 
implemented in v8 :-(

I'd much have preferred fewer iterations and more careful implementation, which 
would have resulted in much less time wasted on the reviewer side...

Anyway, to stop this trainwreck I've fixed this (and a few other small details) 
and applied the patch, but I'd also like to point out that from now on I'll stop 
accepting trivial patches from serial trivial patches contributors that are not 
part of some larger, more substantial work...

Thanks,

	Ingo