linux-kernel - Re: [PATCH v7] x86/setup: get ramdisk parameters only once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160227124429.GA5337@pd.tnic>
Date:	Sat, 27 Feb 2016 13:44:29 +0100
From:	Borislav Petkov <bp@...e.de>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Alexander Kuleshov <kuleshovmail@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Joerg Roedel <jroedel@...e.de>, Dave Young <dyoung@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Baoquan He <bhe@...hat.com>, Mark Salter <msalter@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] x86/setup: get ramdisk parameters only once

On Sat, Feb 27, 2016 at 12:55:46PM +0100, Ingo Molnar wrote:
> So I find it highly annoying that this review feedback was done by Boris, but not 
> implemented in v8 :-(

And I missed it when going over v8. :-(

FWIW, since recently I get the impression that people don't take review
feedback seriously. Starting to think, why even bother...

> I'd much have preferred fewer iterations and more careful implementation, which 
> would have resulted in much less time wasted on the reviewer side...

Agreed.

> Anyway, to stop this trainwreck I've fixed this (and a few other small details) 
> and applied the patch, but I'd also like to point out that from now on I'll stop 
> accepting trivial patches from serial trivial patches contributors that are not 
> part of some larger, more substantial work...

Good idea. ACK.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--