linux-kernel - Re: [PATCH] crypto: algif_hash - correctly handle algos without state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160227171039.GA8420@gondor.apana.org.au>
Date:	Sat, 27 Feb 2016 17:10:39 +0000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: algif_hash - correctly handle algos without state

On Tue, Feb 23, 2016 at 12:01:56PM -0500, Sasha Levin wrote:
> Algorithms without state will cause the creation of a 0 sized array, which
> is undefined outside of structs.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Actually the state size should never be zero and we check it upon
algorithm registration, so how can this possibly happen?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt