linux-kernel - Re: [PATCH 7/7] iio: adc: palmas: Drop IRQF_EARLY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56D1DB19.5030504@kernel.org>
Date:	Sat, 27 Feb 2016 17:21:29 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Grygorii Strashko <grygorii.strashko@...com>,
	Lee Jones <lee.jones@...aro.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Lars-Peter Clausen <lars@...afoo.de>
Cc:	rtc-linux@...glegroups.com, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, nsekhar@...com,
	linux-omap@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>, Nishanth Menon <nm@...com>
Subject: Re: [PATCH 7/7] iio: adc: palmas: Drop IRQF_EARLY_RESUME flag

On 26/02/16 15:42, Grygorii Strashko wrote:
> Palmas gpadc IRQs are nested threaded and this flag is not required for nested
> irqs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend nested_thread
> irqs over system suspend") was merged.
> 
> Cc: Hartmut Knaack <knaack.h@....de>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Peter Meerwald <pmeerw@...erw.net>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Nishanth Menon <nm@...com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/palmas_gpadc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
> index f42eb8a..2bbf0c5 100644
> --- a/drivers/iio/adc/palmas_gpadc.c
> +++ b/drivers/iio/adc/palmas_gpadc.c
> @@ -534,7 +534,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev)
>  	}
>  	ret = request_threaded_irq(adc->irq, NULL,
>  		palmas_gpadc_irq,
> -		IRQF_ONESHOT | IRQF_EARLY_RESUME, dev_name(adc->dev),
> +		IRQF_ONESHOT, dev_name(adc->dev),
>  		adc);
>  	if (ret < 0) {
>  		dev_err(adc->dev,
> @@ -549,7 +549,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev)
>  		adc->irq_auto_0 =  platform_get_irq(pdev, 1);
>  		ret = request_threaded_irq(adc->irq_auto_0, NULL,
>  				palmas_gpadc_irq_auto,
> -				IRQF_ONESHOT | IRQF_EARLY_RESUME,
> +				IRQF_ONESHOT,
>  				"palmas-adc-auto-0", adc);
>  		if (ret < 0) {
>  			dev_err(adc->dev, "request auto0 irq %d failed: %d\n",
> @@ -565,7 +565,7 @@ static int palmas_gpadc_probe(struct platform_device *pdev)
>  		adc->irq_auto_1 =  platform_get_irq(pdev, 2);
>  		ret = request_threaded_irq(adc->irq_auto_1, NULL,
>  				palmas_gpadc_irq_auto,
> -				IRQF_ONESHOT | IRQF_EARLY_RESUME,
> +				IRQF_ONESHOT,
>  				"palmas-adc-auto-1", adc);
>  		if (ret < 0) {
>  			dev_err(adc->dev, "request auto1 irq %d failed: %d\n",
>